|
Back
Midas
Rome
Roody
Rootana
|
Midas DAQ System |
Not logged in |
|
|
06 Mar 2023, Gennaro Tortone, Forum, pull request for PostgreSQL support
|
06 Mar 2023, Konstantin Olchanski, Forum, pull request for PostgreSQL support
|
06 Mar 2023, Gennaro Tortone, Forum, pull request for PostgreSQL support
|
20 Mar 2023, Gennaro Tortone, Forum, pull request for PostgreSQL support
|
24 May 2023, Gennaro Tortone, Forum, pull request for PostgreSQL support
|
18 Jul 2023, Konstantin Olchanski, Forum, pull request for PostgreSQL support
|
21 Jul 2023, Konstantin Olchanski, Forum, pull request for PostgreSQL support
|
21 Jul 2023, Gennaro Tortone, Forum, pull request for PostgreSQL support
|
28 Jul 2023, Stefan Ritt, Forum, pull request for PostgreSQL support
|
09 Aug 2023, Konstantin Olchanski, Forum, pull request for PostgreSQL support
|
|
Message ID: 2559
Entry time: 21 Jul 2023
In reply to: 2556
Reply to this: 2560
|
Author: |
Konstantin Olchanski |
Topic: |
Forum |
Subject: |
pull request for PostgreSQL support |
|
|
> > is there any news regarding this pull request ?
> > (https://bitbucket.org/tmidas/midas/pull-requests/30)
>
> apologies for taking a very long time to review the proposed changes.
>
I merged the PgSql bits by hand - the automatic tools make a dog's breakfast from the history_schema.cxx diffs. Ouch.
history_schema.cxx merged pretty much cleanly, but I have one question about CreateSqlColumn() with sql_strict set to "true". Can you say
more why this is needed? Should this also be made the default for MySQL? The best I can tell the default values are only needed if we write
to SQL but forget to provide values that should not be NULL? But our code never does this? Or this is for reading from SQL, where NULL values
are replaced with the default values? I do not have time to look into this right now, I hope you can clarify it for me?
Also notice the fDownsample is set to zero and cannot be changed. I recommend we set it through the MakeMidasHistoryPgsql() factory method.
Please pull, merge, retest, update the pull request, check that there is no unrelated changes (changes in mlogger.cxx is a direct red flag!)
and we should be able to merge the rest of your stuff pronto.
K.O.
commit e85bb6d37c85f02fc4895cae340ba71ab36de906 (HEAD -> develop, origin/develop, origin/HEAD)
Author: Konstantin Olchanski <olchansk@triumf.ca>
Date: Fri Jul 21 09:45:08 2023 -0700
merge PQSQL history in history_schema.cxx
commit f254ebd60a23c6ee2d4870f3b6b5e8e95a8f1f09
Author: Konstantin Olchanski <olchansk@triumf.ca>
Date: Fri Jul 21 09:19:07 2023 -0700
add PGSQL Makefile bits
commit aa5a35ba221c6f87ae7a811236881499e3d8dcf7
Author: Konstantin Olchanski <olchansk@triumf.ca>
Date: Fri Jul 21 08:51:23 2023 -0700
merge PGSQL support from https://bitbucket.org/gtortone/midas/branch/feature/timescaledb_support except for history_schema.cxx |