ELOG Midas

Back Midas Rome Roody Rootana

Midas DAQ System, Page 98 of 150

Not logged in

Find | Login | Help

Full | Summary | Threaded | Hide attachments

2994 Entries

Goto page Previous 1, 2, 3 ... 97, 98, 99 ... 148, 149, 150 Next

ID	Date	Author	Topic	Subject
436	18 Feb 2008	Jimmy Ngai	Bug Report	Analyzer cannot run as Daemon
Hi All, I'm testing MIDAS SVN rev-4113 on Scientific Linux 5.1 (i386) and the Analyzer can't start as Daemon. What I mean "can't" is that it stops running immediately without leaving any error messages. However, it can run offline or without becoming a Daemon. I have tested with ROOT 5.14e/5.16/5.18 and the "Experiment" example coming with MIDAS and this problem always happens. Any ideas? Best Regards, Jimmy
442	21 Feb 2008	Stefan Ritt	Bug Report	mhttpd safari 3.0.4 redirect problem
> /* start command / > if (getparam("Start")) { > /* for NT: close reply socket before starting subprocess / > - redirect2("?cmd=programs"); > + redirect2("/?cmd=programs"); The second version won't work if mhttpd is run under an Apache proxy. Assume the proxy redirects http://proxy.ca/midas to http://daq.ca:8080 If you now do a redirect to "/?cmd=programs", you will end up at http://proxy.ca/?cmd=programs which is now what you want. I tried to put a "./?cmd=programs", and that bings you to http://proxy.ca/midas/./?cmd=programs which is correctly redirected to http://daq.ca:8080/?cmd=programs I tried with the windows version (ughhh) of Safari and it worked for me. So give it a try, the change is committed. > ODB corruption happens here: > > sprintf(str, "/Programs/%s/Start command", name); > - db_get_value(hDB, 0, str, command, &size, TID_STRING, TRUE); > + db_get_value(hDB, 0, str, command, &size, TID_STRING, FALSE); > if (command[0]) { > ss_system(command); > > It looks like db_get_value() would corrupt ODB if given funny "str". When Safari explodes, > funny strings are generated. What happes is an endless redirect from xxxx -> xxxx?cmd=Programs. So in the end you have http://url.ca?cmd=programs?cmd=programs?cmd=programs?cmd=programs.... and in the end you get a stack overflow, which busts all. > The simple fix is to replace "TRUE" with "FALSE", then at least db_get_value() does not try to make bogus > entries in ODB. I changed both butting FALSE there and adding if (strchr(name, '?')) strchr(name, '?') = 0; which keeps the URL short. So for me it looks fine at the moment, but I cannot guarantee that everything works, so keep an eye open on that.
444	21 Feb 2008	Konstantin Olchanski	Bug Report	potential memory corruption in odb,c:extract_key()
> It looks like ODB function extract_key() will overwrite the array pointed to by "key_name" if given an odb > path with very long names (as seems to happen when redirection explodes in the Safari web browser, via > db_get_value(TRUE) via mhttpd "start program" button). All callers of this function seem to provide 256 > byte strings, so the problem would not show up in normal use - only when abnormal odb paths are being > parsed. Proposed solution is to add a "length" argument to this function. (Actually ODB path elements > should be restricted to NAME_LENGTH (32 bytes), right?). K.O. This is fixed in svn revision 4129. K.O.
445	26 Feb 2008	Denis Bilenko	Bug Report	NEED_SHLIB=1 is broken
I have the exact same problem with midas rev. 4129. `make NEED_SHLIB=1` doesn't work. To fix it apply this patch to Makefile Index: Makefile =================================================================== --- Makefile (revision 4129) +++ Makefile (working copy) @@ -270,7 +270,7 @@ OBJS = $(LIB_DIR)/midas.o $(LIB_DIR)/system.o $(LIB_DIR)/mrpc.o \ $(LIB_DIR)/odb.o $(LIB_DIR)/ybos.o $(LIB_DIR)/ftplib.o \ - $(LIB_DIR)/mxml.o $(LIB_DIR)/cnaf_callback.o \ + $(LIB_DIR)/mxml.o \ $(LIB_DIR)/history.o $(LIB_DIR)/alarm.o $(LIB_DIR)/elog.o ifdef NEED_STRLCPY i.e. remove cnaf_callback.o which causes the link errors. I propose that libmidas.so is built by default, so when something breaks it won't go unnoticed.
446	27 Feb 2008	Konstantin Olchanski	Bug Report	NEED_SHLIB=1 is broken
--- Makefile (revision 4129) +++ Makefile (working copy) - $(LIB_DIR)/mxml.o $(LIB_DIR)/cnaf_callback.o \ + $(LIB_DIR)/mxml.o \ > i.e. remove cnaf_callback.o which causes the link errors. Hi, Denis - I confirm that cnaf_callback.c is only used by MIDAS frontends that implement CAMAC functions and that it should not required for building the MIDAS library. I am now looking at removing it from libmidas. > I propose that libmidas.so is built by default, so when something breaks it won't go unnoticed We have been through this before and decided that shared libraries are bad and we do not want to use them. The option for building libmidas.so was preserved, though. Not to refight old wars, on reason against using shared libraries was version skew - one could never be sure what version of midas is being used - depending on the PATH, LD_LIBRARY_PATH, rpath settings, etc. There were other reasons, perhaps practical, perhaps with the mserver. The main problem with "just build it", is that then the rest of midas will link against it bringing back all the problems we solved by going away from using shared libraries. So back to your proposal about building libmidas.so - can you look and see if you can do the Python bindings with a statically linked midas library? I know it is possible with Perl bindings - perl creates it's own shared library containing perl api glue linked against a foreign static library libfoo.a , so in theory, the shared library is not needed. But perhaps, Python do things differently... K.O.
448	27 Feb 2008	Konstantin Olchanski	Bug Report	mhttpd: cannot attach history to elog
From "history" pages, the "create elog" button stopped working - it takes us to the elog entry form, but then, the "submit" button does not create any elog entries, instead dumps us into an invalid history display. This is using the internal elog. This change in mhttpd.c::show_elog_new() makes it work again: - ("<body><form method=\"POST\" action=\"./\" enctype=\"multipart/form-data\">\n"); + ("<body><form method=\"POST\" action=\"/EL/\" enctype=\"multipart/form-data\">\n"); Problem and fix confirmed with Linux/firefox and MacOS/firefox and Safari. K.O.
449	28 Feb 2008	Konstantin Olchanski	Bug Report	mhttpd: cannot attach history to elog
> From "history" pages, the "create elog" button stopped working - it takes us to the elog entry form, but > then, the "submit" button does not create any elog entries, instead dumps us into an invalid history > display. This is using the internal elog. > > This change in mhttpd.c::show_elog_new() makes it work again: > - ("<body><form method=\"POST\" action=\"./\" enctype=\"multipart/form-data\">\n"); > + ("<body><form method=\"POST\" action=\"/EL/\" enctype=\"multipart/form-data\">\n"); This was a problem with relative URLs and it is now fixed. Svn revision 4131, fixes: delete elog, make elog from odb, make elog from history. K.O.
450	29 Feb 2008	Denis Bilenko	Bug Report	NEED_SHLIB=1 is broken
Having libmidas.so is absolutely necessary for pymidas to work. If there was no such option in Makefile pymidas users would have to build it themselves. What I proposed though is that you change Makefile so it builds libmidas.so in addition to (not instead of) static library. So if someone prefer to build binaries statically they may continue to do so. On other hand when someone needs a shared library they won't discover that it can't be easily built.
452	07 Mar 2008	Randolf Pohl	Bug Report	array overflows and other bugs
Hi, I have just compiled MIDAS svn 4132 on a fresh SuSE 10.3 x86_64 system and gcc found a bunch of bugs, I guess. > uname -a Linux pc 2.6.22.17-0.1-default #1 SMP 2008/02/10 20:01:04 UTC x86_64 x86_64 x86_64 GNU/Linux > gcc --version gcc (GCC) 4.2.1 (SUSE Linux) I see loads of warnings during compile, most of which I know from earlier compiles: * warning: dereferencing type-punned pointer will break strict-aliasing rules * warning: pointer targets in passing argument 3 of 'getsockname' differ in signedness But then there is a new one (in fact lots of this one), and brief inspection suggests this is a true bug with the possibility of truly nasty consequences. (1)========================= src/midas.c:7398: warning: array subscript is above array bounds Inspection of midas.c: if (i == MAX_DEFRAG_EVENTS) { /* no buffer available -> no first fragment received / 7398: free(defrag_buffer[i].pevent); memset(&defrag_buffer[i].event_id, 0, sizeof(EVENT_DEFRAG_BUFFER)); cm_msg(MERROR, "bm_defragement_event", "Received fragment without first fragment (ID %d) Ser#:%d", pevent->event_id & 0x0FFF, pevent->serial_number); return; } And midas.c line 7297: EVENT_DEFRAG_BUFFER defrag_buffer[MAX_DEFRAG_EVENTS]; So, if(i==MAX_DEFRAG_EVENTS) free(defrag_buffer[i]). I guess this is an off-by-one bug. (2)========================== src/midas.c:2958: warning: array subscript is above array bounds for (i = 0; i < 13; i++) 2958 if (trans_name[i].transition == transition) break; Holy cow, hard-coded "13" in the code! Should be a #define, shouldn't it? Now look at midas.c lines 94ff: struct { int transition; char name[32]; } trans_name[] = { { TR_START, "START",}, { TR_STOP, "STOP",}, { TR_PAUSE, "PAUSE",}, { TR_RESUME, "RESUME",}, { TR_DEFERRED, "DEFERRED",}, { 0, "",},}; There is no trans_name[12]. The trans_name[12] shows up in line 2894 and 2790, too. (3)============================= mfe.c: src/mfe.c:412: warning: array subscript is above array bounds src/mfe.c:311: warning: array subscript is above array bounds src/mfe.c:340: warning: array subscript is above array bounds 412: device_drv->dd(CMD_GET_DEMAND, device_drv->dd_info, i, &device_drv->mt_buffer->channel[i].array[CMD_GET_DEMAND]); for (cmd = CMD_GET_FIRST; cmd <= CMD_GET_LAST; cmd++) { (..) 311: device_drv->mt_buffer->channel[current_channel].array[cmd] = value; for (cmd = CMD_GET_FIRST; cmd <= CMD_GET_LAST; cmd++) { (..) 340: device_drv->mt_buffer->channel[i].array[cmd] = value; CMD_GET_DEMAND is in include/midas.h: #define CMD_GET_DEMAND CMD_GET_DIRECT // = 20 I haven't even tried to understand mfe.c, nor did I read it. But I suspect the thing should always be something like ....array[cmd-CMD_GET_FIRST] so array[] is indexed from [0], not from an arbitrary number that depends on the number of commands you insert before line 698 in midas.h. But please could the author of this check this very carefully? (4)========================= src/lazylogger.c:1957: warning: array subscript is below array bounds if ((channel < 0) && (lazyinfo[channel].hKey != 0)) That is lazyinfo[something below zero]. (5)============================= More warnings an expert might want to have a look at: warning: deprecated conversion from string constant to 'char' src/fal.c:106: warning: non-local variable '<anonymous struct> out_info' uses anonymous type * src/fal.c:3064: warning: non-local variable '<anonymous struct> eb' uses anonymous type I attach the full output of make. Could someone knowledgeable please have a look at these warnings and fix them? They make me a bit nervous when thinking about data integrity, and there are now so many that they actually start to hide serious stuff like the ones I presented. Oh, I got rid of the "dereferencing type-punned pointer" thing by adding "-fno-strict-aliasing" as a compiler flag. Was suggested on the Web. Seemed to have worked during data taking (the data look reasonable :-). Is that a possible fix/workaround? Cheers, Randolf
Attachment 1: out.0.make
cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/midas.o src/midas.c src/midas.c: In function 'bm_open_buffer': src/midas.c:4020: warning: dereferencing type-punned pointer will break strict-aliasing rules src/midas.c: In function 'rpc_server_connect': src/midas.c:8259: warning: pointer targets in passing argument 3 of 'getsockname' differ in signedness src/midas.c:8261: warning: pointer targets in passing argument 3 of 'getsockname' differ in signedness src/midas.c:8263: warning: pointer targets in passing argument 3 of 'getsockname' differ in signedness src/midas.c:8376: warning: pointer targets in passing argument 3 of 'accept' differ in signedness src/midas.c:8378: warning: pointer targets in passing argument 3 of 'accept' differ in signedness src/midas.c:8380: warning: pointer targets in passing argument 3 of 'accept' differ in signedness src/midas.c: In function 'rpc_register_server': src/midas.c:10533: warning: pointer targets in passing argument 3 of 'getsockname' differ in signedness src/midas.c: In function 'rpc_server_accept': src/midas.c:11230: warning: pointer targets in passing argument 3 of 'accept' differ in signedness src/midas.c:11239: warning: pointer targets in passing argument 3 of 'getpeername' differ in signedness src/midas.c: In function 'rpc_client_accept': src/midas.c:11493: warning: pointer targets in passing argument 3 of 'accept' differ in signedness src/midas.c: In function 'bm_defragment_event': src/midas.c:7398: warning: array subscript is above array bounds src/midas.c: In function 'cm_register_deferred_transition': src/midas.c:2958: warning: array subscript is above array bounds src/midas.c:2958: warning: array subscript is above array bounds src/midas.c:2958: warning: array subscript is above array bounds src/midas.c:2958: warning: array subscript is above array bounds src/midas.c:2958: warning: array subscript is above array bounds src/midas.c:2958: warning: array subscript is above array bounds src/midas.c:2958: warning: array subscript is above array bounds src/midas.c: In function 'cm_set_transition_sequence': src/midas.c:2894: warning: array subscript is above array bounds src/midas.c:2894: warning: array subscript is above array bounds src/midas.c:2894: warning: array subscript is above array bounds src/midas.c:2894: warning: array subscript is above array bounds src/midas.c:2894: warning: array subscript is above array bounds src/midas.c:2894: warning: array subscript is above array bounds src/midas.c:2894: warning: array subscript is above array bounds src/midas.c: In function 'cm_deregister_transition': src/midas.c:2849: warning: array subscript is above array bounds src/midas.c:2849: warning: array subscript is above array bounds src/midas.c:2849: warning: array subscript is above array bounds src/midas.c:2849: warning: array subscript is above array bounds src/midas.c:2849: warning: array subscript is above array bounds src/midas.c:2849: warning: array subscript is above array bounds src/midas.c:2849: warning: array subscript is above array bounds src/midas.c: In function 'cm_register_transition': src/midas.c:2790: warning: array subscript is above array bounds src/midas.c:2790: warning: array subscript is above array bounds src/midas.c:2790: warning: array subscript is above array bounds src/midas.c:2790: warning: array subscript is above array bounds src/midas.c:2790: warning: array subscript is above array bounds src/midas.c:2790: warning: array subscript is above array bounds src/midas.c:2790: warning: array subscript is above array bounds cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/system.o src/system.c src/system.c: In function 'ss_suspend_init_ipc': src/system.c:2948: warning: pointer targets in passing argument 3 of 'getsockname' differ in signedness src/system.c: In function 'ss_suspend': src/system.c:3416: warning: pointer targets in passing argument 6 of 'recvfrom' differ in signedness src/system.c:3443: warning: pointer targets in passing argument 6 of 'recvfrom' differ in signedness cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/mrpc.o src/mrpc.c cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/odb.o src/odb.c src/odb.c: In function 'db_open_database': src/odb.c:891: warning: dereferencing type-punned pointer will break strict-aliasing rules src/odb.c: In function 'db_lock_database': src/odb.c:1441: warning: dereferencing type-punned pointer will break strict-aliasing rules cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/ybos.o src/ybos.c cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/ftplib.o src/ftplib.c src/ftplib.c: In function 'ftp_data': src/ftplib.c:288: warning: pointer targets in passing argument 3 of 'getsockname' differ in signedness src/ftplib.c:310: warning: pointer targets in passing argument 3 of 'accept' differ in signedness cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/mxml.o ../mxml/mxml.c cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/history.o src/history.c cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/alarm.o src/alarm.c cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/elog.o src/elog.c cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/strlcpy.o ../mxml/strlcpy.c rm -f linux/lib/libmidas.a ar -crv linux/lib/libmidas.a linux/lib/midas.o linux/lib/system.o linux/lib/mrpc.o linux/lib/odb.o linux/lib/ybos.o linux/lib/ftplib.o linux/lib/mxml.o linux/lib/history.o linux/lib/alarm.o linux/lib/elog.o linux/lib/strlcpy.o a - linux/lib/midas.o a - linux/lib/system.o a - linux/lib/mrpc.o a - linux/lib/odb.o a - linux/lib/ybos.o a - linux/lib/ftplib.o a - linux/lib/mxml.o a - linux/lib/history.o a - linux/lib/alarm.o a - linux/lib/elog.o a - linux/lib/strlcpy.o cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/mana.o src/mana.c g++ -DUSE_ROOT -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -pthread -m64 -I/usr/local/packages/root/pro/include -o linux/lib/rmana.o src/mana.c src/mana.c:186: warning: deprecated conversion from string constant to 'char' src/mana.c: In function 'void add_data_dir(char, char)': src/mana.c:429: warning: deprecated conversion from string constant to 'char' src/mana.c: In function 'EVENT_DEF* db_get_event_definition(short int)': src/mana.c:484: warning: deprecated conversion from string constant to 'char' src/mana.c:500: warning: deprecated conversion from string constant to 'char' src/mana.c:505: warning: deprecated conversion from string constant to 'char' src/mana.c:516: warning: deprecated conversion from string constant to 'char' src/mana.c:518: warning: deprecated conversion from string constant to 'char' src/mana.c:520: warning: deprecated conversion from string constant to 'char' src/mana.c:522: warning: deprecated conversion from string constant to 'char' src/mana.c:524: warning: deprecated conversion from string constant to 'char' src/mana.c:526: warning: deprecated conversion from string constant to 'char' src/mana.c:534: warning: deprecated conversion from string constant to 'char' src/mana.c: In function 'INT bor(INT, char)': src/mana.c:1745: warning: deprecated conversion from string constant to 'char' src/mana.c: In function 'INT process_event(ANALYZE_REQUEST, EVENT_HEADER)': src/mana.c:3230: warning: deprecated conversion from string constant to 'char' src/mana.c: In function 'void register_requests()': src/mana.c:3465: warning: deprecated conversion from string constant to 'char' src/mana.c:3479: warning: deprecated conversion from string constant to 'char' src/mana.c: In function 'TCutG cut_book(const char)': src/mana.c:3562: warning: deprecated conversion from string constant to 'char' src/mana.c: In function 'INT bevid_2_mheader(EVENT_HEADER, DWORD)': src/mana.c:3864: warning: deprecated conversion from string constant to 'char' src/mana.c: In function 'void odb_load(EVENT_HEADER)': src/mana.c:3910: warning: deprecated conversion from string constant to 'char' src/mana.c:3921: warning: deprecated conversion from string constant to 'char' src/mana.c:3932: warning: deprecated conversion from string constant to 'char' src/mana.c: In function 'MA_FILE ma_open(char)': src/mana.c:4031: warning: deprecated conversion from string constant to 'char' src/mana.c: In function 'INT analyze_run(INT, char, char)': src/mana.c:4252: warning: deprecated conversion from string constant to 'char' src/mana.c: In function 'int main(int, char)': src/mana.c:5618: warning: deprecated conversion from string constant to 'char' src/mana.c:5682: warning: deprecated conversion from string constant to 'char' cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/cnaf_callback.o src/cnaf_callback.c cc -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/mfe.o src/mfe.c src/mfe.c: In function 'scheduler': src/mfe.c:1869: warning: pointer targets in passing argument 5 of 'db_get_value' differ in signedness src/mfe.c:2042: warning: pointer targets in passing argument 5 of 'db_get_value' differ in signedness src/mfe.c:2051: warning: pointer targets in passing argument 5 of 'db_get_value' differ in signedness src/mfe.c: In function 'device_driver': src/mfe.c:412: warning: array subscript is above array bounds src/mfe.c: In function 'sc_thread': src/mfe.c:311: warning: array subscript is above array bounds src/mfe.c:340: warning: array subscript is above array bounds g++ -Dextname -DMANA_LITE -c -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/lib/fal.o src/fal.c src/fal.c:65: warning: deprecated conversion from string constant to 'char' src/fal.c:106: warning: non-local variable '<anonymous struct> out_info' uses anonymous type src/fal.c:118: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c:122: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'void logger_init()': src/fal.c:252: warning: deprecated conversion from string constant to 'char' src/fal.c:256: warning: deprecated conversion from string constant to 'char' src/fal.c:260: warning: deprecated conversion from string constant to 'char' src/fal.c:263: warning: deprecated conversion from string constant to 'char' src/fal.c:267: warning: deprecated conversion from string constant to 'char' src/fal.c:271: warning: deprecated conversion from string constant to 'char' src/fal.c:274: warning: deprecated conversion from string constant to 'char' src/fal.c:277: warning: deprecated conversion from string constant to 'char' src/fal.c:280: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'void odb_save(char)': src/fal.c:335: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'INT ftp_open(char, FTP_CON)': src/fal.c:1048: warning: deprecated conversion from string constant to 'char' src/fal.c:1052: warning: deprecated conversion from string constant to 'char' src/fal.c:1056: warning: deprecated conversion from string constant to 'char' src/fal.c:1056: warning: deprecated conversion from string constant to 'char' src/fal.c:1061: warning: deprecated conversion from string constant to 'char' src/fal.c:1066: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'INT midas_log_open(LOG_CHN, INT)': src/fal.c:1194: warning: dereferencing type-punned pointer will break strict-aliasing rules src/fal.c: In function 'EVENT_DEF* db_get_event_definition(short int)': src/fal.c:1321: warning: deprecated conversion from string constant to 'char' src/fal.c:1337: warning: deprecated conversion from string constant to 'char' src/fal.c:1347: warning: deprecated conversion from string constant to 'char' src/fal.c:1349: warning: deprecated conversion from string constant to 'char' src/fal.c:1351: warning: deprecated conversion from string constant to 'char' src/fal.c:1353: warning: deprecated conversion from string constant to 'char' src/fal.c:1355: warning: deprecated conversion from string constant to 'char' src/fal.c:1357: warning: deprecated conversion from string constant to 'char' src/fal.c:1365: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'INT dump_log_open(LOG_CHN, INT)': src/fal.c:1582: warning: dereferencing type-punned pointer will break strict-aliasing rules src/fal.c: In function 'INT ascii_log_open(LOG_CHN, INT)': src/fal.c:1803: warning: dereferencing type-punned pointer will break strict-aliasing rules src/fal.c: In function 'INT log_open(LOG_CHN, INT)': src/fal.c:2293: warning: deprecated conversion from string constant to 'char' src/fal.c:2296: warning: deprecated conversion from string constant to 'char' src/fal.c:2299: warning: deprecated conversion from string constant to 'char' src/fal.c:2302: warning: deprecated conversion from string constant to 'char' src/fal.c:2309: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'INT log_write(LOG_CHN, EVENT_HEADER)': src/fal.c:2414: warning: deprecated conversion from string constant to 'char' src/fal.c:2439: warning: deprecated conversion from string constant to 'char' src/fal.c:2477: warning: deprecated conversion from string constant to 'char' src/fal.c:2478: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'INT open_history()': src/fal.c:2523: warning: deprecated conversion from string constant to 'char' src/fal.c:2525: warning: deprecated conversion from string constant to 'char' src/fal.c:2530: warning: deprecated conversion from string constant to 'char' src/fal.c:2531: warning: deprecated conversion from string constant to 'char' src/fal.c:2533: warning: deprecated conversion from string constant to 'char' src/fal.c:2535: warning: deprecated conversion from string constant to 'char' src/fal.c:2538: warning: deprecated conversion from string constant to 'char' src/fal.c:2538: warning: deprecated conversion from string constant to 'char' src/fal.c:2540: warning: deprecated conversion from string constant to 'char' src/fal.c:2543: warning: deprecated conversion from string constant to 'char' src/fal.c:2543: warning: deprecated conversion from string constant to 'char' src/fal.c:2550: warning: deprecated conversion from string constant to 'char' src/fal.c:2564: warning: deprecated conversion from string constant to 'char' src/fal.c:2573: warning: deprecated conversion from string constant to 'char' src/fal.c:2581: warning: deprecated conversion from string constant to 'char' src/fal.c:2613: warning: deprecated conversion from string constant to 'char' src/fal.c:2737: warning: deprecated conversion from string constant to 'char' src/fal.c:2864: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'void close_history()': src/fal.c:2878: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'INT log_callback(INT, void*)': src/fal.c:2983: warning: deprecated conversion from string constant to 'char' src/fal.c:2992: warning: deprecated conversion from string constant to 'char' src/fal.c:3007: warning: deprecated conversion from string constant to 'char' src/fal.c:3011: warning: deprecated conversion from string constant to 'char' src/fal.c:3015: warning: deprecated conversion from string constant to 'char' src/fal.c:3040: warning: deprecated conversion from string constant to 'char' src/fal.c:3042: warning: deprecated conversion from string constant to 'char' src/fal.c: At global scope: src/fal.c:3064: warning: non-local variable '<anonymous struct> eb' uses anonymous type src/fal.c: In function 'INT tr_start(INT, char)': src/fal.c:3092: warning: deprecated conversion from string constant to 'char' src/fal.c:3097: warning: deprecated conversion from string constant to 'char' src/fal.c:3101: warning: deprecated conversion from string constant to 'char' src/fal.c:3104: warning: deprecated conversion from string constant to 'char' src/fal.c:3107: warning: deprecated conversion from string constant to 'char' src/fal.c:3114: warning: deprecated conversion from string constant to 'char' src/fal.c:3153: warning: deprecated conversion from string constant to 'char' src/fal.c:3161: warning: deprecated conversion from string constant to 'char' src/fal.c:3205: warning: deprecated conversion from string constant to 'char' src/fal.c:3207: warning: deprecated conversion from string constant to 'char' src/fal.c:3209: warning: deprecated conversion from string constant to 'char' src/fal.c:3226: warning: deprecated conversion from string constant to 'char' src/fal.c:3272: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'INT tr_stop(INT, char)': src/fal.c:3491: warning: deprecated conversion from string constant to 'char' src/fal.c:3496: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'void add_data_dir(char, char)': src/fal.c:3537: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'INT mana_init()': src/fal.c:4395: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'INT register_equipment()': src/fal.c:4657: warning: deprecated conversion from string constant to 'char' src/fal.c:4660: warning: deprecated conversion from string constant to 'char' src/fal.c:4683: warning: deprecated conversion from string constant to 'char' src/fal.c:4687: warning: deprecated conversion from string constant to 'char' src/fal.c:4694: warning: deprecated conversion from string constant to 'char' src/fal.c:4696: warning: deprecated conversion from string constant to 'char' src/fal.c:4761: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'void register_requests()': src/fal.c:4924: warning: deprecated conversion from string constant to 'char' src/fal.c:4934: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'INT scheduler()': src/fal.c:5407: warning: deprecated conversion from string constant to 'char' src/fal.c:5496: warning: deprecated conversion from string constant to 'char' src/fal.c: In function 'int main(int, char*)': src/fal.c:5616: warning: deprecated conversion from string constant to 'char' cc -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/bin/mserver src/mserver.c linux/lib/libmidas.a -lutil -lpthread -lz cc -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/bin/mhttpd src/mhttpd.c src/mgd.c linux/lib/libmidas.a -lutil -lpthread -lz -lm g++ -g -O3 -Wall -Wuninitialized -Iinclude -Idrivers -I../mxml -Llinux/lib -DINCLUDE_FTPLIB -D_LARGEFILE64_SOURCE -DHAVE_ROOT -pthread -m64 -I/usr/local/packages/root/pro/include -DHAVE_ZLIB -DOS_LINUX -fPIC -Wno-unused-function -o linux/bin/mlogger src/mlogger.c linux/lib/libmidas.a -L/usr/local/packages/root/pro/lib -lCore -lCint -lRIO -lNet -lHist -lGraf -lGraf3d -lGpad -lTree -lRint -lPostscript -lMatrix -lPhysics -pthread -lm -ldl -rdynamic -Wl,-rpath,/usr/local/packages/root/pro/lib -lutil -lpthread -lz src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' src/mlogger.c:78: warning: deprecated conversion from string constant to 'char' ... 156 more lines ...
453	07 Mar 2008	Stefan Ritt	Bug Report	array overflows and other bugs
> I have just compiled MIDAS svn 4132 on a fresh SuSE 10.3 x86_64 system and gcc > found a bunch of bugs, I guess. Ahh, great! gcc is getting more and more clever. Each time gcc is updated, it finds a few new issues. Indeed some are real bugs, and I will work down the list as time permits. I see however no immediate thread (you are not using fragmented events, a transition 12 never occurs, etc.). Issue #4 from your list has to be checked by Pierre-Andre.
462	10 Mar 2008	Stefan Ritt	Bug Report	array overflows and other bugs
There were some trivial and some non-trivial issues. Glad the compiled picked up on this! > I see loads of warnings during compile, most of which I know from earlier > compiles: > * warning: dereferencing type-punned pointer will break strict-aliasing rules > * warning: pointer targets in passing argument 3 of 'getsockname' differ in > signedness I ignore these for the moment until I have a gcc 4.2 myself (we use Scientific Linux 5 which has gcc 4.1 for the moment). As Randolph pointed out correctly you can make gcc shut up by a proper flag there. The warnings have no influence on the stability of midas. > (1)========================= > src/midas.c:7398: warning: array subscript is above array bounds > Inspection of midas.c: > > if (i == MAX_DEFRAG_EVENTS) { > /* no buffer available -> no first fragment received / > 7398: free(defrag_buffer[i].pevent); > memset(&defrag_buffer[i].event_id, 0, sizeof(EVENT_DEFRAG_BUFFER)); > cm_msg(MERROR, "bm_defragement_event", > "Received fragment without first fragment (ID %d) Ser#:%d", > pevent->event_id & 0x0FFF, pevent->serial_number); > return; > } The free() was just wrong at that place, I removed it. > (2)========================== > src/midas.c:2958: warning: array subscript is above array bounds > > for (i = 0; i < 13; i++) > 2958 if (trans_name[i].transition == transition) > break; Fixed that by for (i=0 ;; i++) if (trans_name[i].name[0] == 0 \|\| trans_name[i].transition == transition) break; Since trans_name[i].name = "" indicates the end of the list. > (3)============================= > mfe.c: > src/mfe.c:412: warning: array subscript is above array bounds > src/mfe.c:311: warning: array subscript is above array bounds > src/mfe.c:340: warning: array subscript is above array bounds > > 412: device_drv->dd(CMD_GET_DEMAND, device_drv->dd_info, i, > &device_drv->mt_buffer->channel[i].array[CMD_GET_DEMAND]); The code at 412 was wrong there, the demand value is queried later by the device driver directly. For the other two occurences (311 and 340) I had to really increase the array size by one. This issue can cause segfaults if you have a slow control front-end which uses multithreading (not many people use it except me). > (4)========================= > src/lazylogger.c:1957: warning: array subscript is below array bounds > > if ((channel < 0) && (lazyinfo[channel].hKey != 0)) > > That is lazyinfo[something below zero]. This has to be fixed by Pierre. I guess an or instead of an and would do it, but I'm not 100% sure. > (5)============================= > More warnings an expert might want to have a look at: > > warning: deprecated conversion from string constant to 'char' > > src/fal.c:106: warning: non-local variable '<anonymous struct> out_info' > uses anonymous type > * src/fal.c:3064: warning: non-local variable '<anonymous struct> eb' uses > anonymous type > > I attach the full output of make. > Could someone knowledgeable please have a look at these warnings and fix them? Uahhh. Especially the "const char" vs. "char" is in principle right, but will cause a major rework. Probably hundreds of occations have to be fixed. Many strings must be declared const, others not. It will help the programmer to find some errors during compile which would later show up only during runtime (like writing into a fixed string), but I only will go through that when I have gcc 4.2 installed myself, and have two free days to work on this ;-) > They make me a bit nervous when thinking about data integrity, and > there are now so many that they actually start to hide serious stuff > like the ones I presented. Except the slow control stuff (which only is an issue for multithreaded frontends) none of the above things will have an influence on the data integrity. But I agree that they should be fixed. - Stefan
480	20 May 2008	Konstantin Olchanski	Bug Report	pending problems and fixes from triumf
Here is the list of known problems I am aware of and of fixes not yet committed to midas svn:
481	20 May 2008	Konstantin Olchanski	Bug Report	pending problems and fixes from triumf
Here is the list of known problems I am aware of and of fixes not yet committed to midas svn: 1) added variable /equiment/foo/common/PerVariableHistory breaks stuff (mostly mhttpd). It is not clear how this problem escaped my pre-commit checks. This per-equipment variable enables the per-variable history for the given equipment. Local consensus is that this variable should not be in "common" and should not be in "settings". Probably in "/history"? Or have only one variable to enable this for all equipments at once (like we do in ALPHA). 2) writing compressed midas files (foo.mid.gz) crashes the mlogger when file size reaches 2 GBytes. This problem could be new in SL5.1. 3) when a midas client becomes unresponsive, runs cannot be stopped using the "stop" button in mhttpd. This is because cm_transition() loops over all attached clients, but never removes clients that are known to be dead. Proposed fix is to call cm_check_client() for each client before calling their rpc transition handler. 4) the discussed before fix for reading broken history files (skip bad data). 5) mhttpd history "export" button needs to be fixed (by request from ALPHA). At present it either does not return all exiting data or crashes mhttpd. (no fix) 6) mhttpd ODB editor in "set value" page, the "cancel" button is broken (needs to be corrected for "relative URL"). (no fix) 7) mhttpd needs AJAX-style methods for reading and writing ODB. (no fix) K.O.
483	28 May 2008	Konstantin Olchanski	Bug Report	pending problems and fixes from triumf
> Here is the list of known problems I am aware of and of fixes not yet committed > to midas svn: > > 1) added variable /equiment/foo/common/PerVariableHistory corrected in svn revision 4203, read http://savannah.psi.ch/viewcvs/trunk/src/mlogger.c?root=midas&rev=4203&sortby=rev&view=log > 2) writing compressed midas files (foo.mid.gz) crashes the mlogger when file > size reaches 2 GBytes. This problem could be new in SL5.1. (no change) > 3) when a midas client becomes unresponsive, runs cannot be stopped using the > "stop" button in mhttpd. This is because cm_transition() loops over all attached > clients, but never removes clients that are known to be dead. Proposed fix is to > call cm_check_client() for each client before calling their rpc transition handler. Fixed in SVN revision 4198, read http://savannah.psi.ch/viewcvs/trunk/src/midas.c?root=midas&rev=4201&sortby=rev&view=log > 4) the discussed before fix for reading broken history files (skip bad data). Fixed in SVN revision 4202, read https://ladd00.triumf.ca/elog/Midas/482 > 5) mhttpd history "export" button needs to be fixed (by request from ALPHA). At > present it either does not return all exiting data or crashes mhttpd. (no fix) (no change) > 6) mhttpd ODB editor in "set value" page, the "cancel" button is broken (needs > to be corrected for "relative URL"). Apply this patch to src/mhttpd.c @@ -11156,10 +11190,7 @@ sprintf(str, "SC/%s/%s", eq_name, group); redirect(str); } else { - strlcpy(str, path, sizeof(str)); - if (strrchr(str, '/')) - strlcpy(str, strrchr(str, '/')+1, sizeof(str)); - redirect(str); + redirect("./"); } > 7) mhttpd needs AJAX-style methods for reading and writing ODB. (no fix) (no change) K.O.
484	29 May 2008	Konstantin Olchanski	Bug Report	pending problems and fixes from triumf
> > Here is the list of known problems I am aware of and of fixes not yet committed to midas svn: > > 1) added variable /equiment/foo/common/PerVariableHistory > > corrected in svn revision 4203, read > http://savannah.psi.ch/viewcvs/trunk/src/mlogger.c?root=midas&rev=4203&sortby=rev&view=log Was still broken - all should work in revision 4207. > > 2) writing compressed midas files (foo.mid.gz) crashes the mlogger when file > > size reaches 2 GBytes. This problem could be new in SL5.1. It turns out that on SL5 and SL5.1 (and others?) the 32-bit version of ZLIB opens the compressed output file without the O_LARGEFILE flag, this limits the file size to 2 GB. Fixed by opening the file ourselves, then attach compression stream using gzdopen(). Revision 4207. (Not tested on Windows - may be broken!) > > 5) mhttpd history "export" button needs to be fixed (by request from ALPHA). At > > present it either does not return all exiting data or crashes mhttpd. (no fix) > > (no change) > > > 6) mhttpd ODB editor in "set value" page, the "cancel" button is broken (needs > > to be corrected for "relative URL"). > > Apply this patch to src/mhttpd.c > > @@ -11156,10 +11190,7 @@ > sprintf(str, "SC/%s/%s", eq_name, group); > redirect(str); > } else { > - strlcpy(str, path, sizeof(str)); > - if (strrchr(str, '/')) > - strlcpy(str, strrchr(str, '/')+1, sizeof(str)); > - redirect(str); > + redirect("./"); > } > > > 7) mhttpd needs AJAX-style methods for reading and writing ODB. (no fix) > > (no change) > > K.O.
503	10 Oct 2008	Konstantin Olchanski	Bug Report	mhttpd "messages" broken
mhttpd "messages" page stopped working after svn revision 4327 because of uninitialized variable "filename2" in midas.c:cm_message_retrieve(). Attached patch fixes the problem for me. K.O. --- src/midas.c (revision 4342) +++ src/midas.c (working copy) @@ -978,6 +978,8 @@ size = sizeof(filename); db_get_value(hDB, 0, "/Logger/Message file", filename, &size, TID_STRING, TRUE); + strlcpy(filename2, filename, sizeof(filename2)); + if (strchr(filename, '%')) { /* replace strings such as midas_%y%m%d.mid with current date */ tzset();
504	11 Oct 2008	Stefan Ritt	Bug Report	mhttpd "messages" broken
> mhttpd "messages" page stopped working after svn revision 4327 because of uninitialized variable > "filename2" in midas.c:cm_message_retrieve(). Attached patch fixes the problem for me. > K.O. > > > --- src/midas.c (revision 4342) > +++ src/midas.c (working copy) > @@ -978,6 +978,8 @@ > size = sizeof(filename); > db_get_value(hDB, 0, "/Logger/Message file", filename, &size, TID_STRING, TRUE); > > + strlcpy(filename2, filename, sizeof(filename2)); > + > if (strchr(filename, '%')) { > /* replace strings such as midas_%y%m%d.mid with current date */ > tzset(); Ups, was my fault, sorry. I committed your change.
510	20 Oct 2008	Suzannah Daviel	Bug Report	custom web pages: customscript buttons and start/stop buttons generate errors
I am using an external Custom web page via a link in the ODB in /Custom, and Javascript to add customscript button(s) and run start/stop buttons. After executing these buttons, instead of returning to the custom page, or to the Midas main status page, there is an error page generated: Invalid custom page: NULL path and the URL is http://lxfred:8082/CS/ The behaviour is the same whether the custom page replaces the main status page or not. I am using MIDAS version 2.0.0 mhttpd.c SVN Rev 4282 In an older version of mhttpd.c, buttons of this type used to return to the Midas main status page regardless of whether the custom page replaced the status page. I found this behaviour annoying, and I made a custom mhttpd.c that returned to the custom page. Would it be possible to fix this problem, and to return to the custom page after pressing the buttons? Here is the Javascript to add the buttons: <script type="text/javascript"> var rstate = '<odb src="/runinfo/run state">' if (rstate == 1) // stopped document.write('<input name="cmd" value="Start" type="submit">') else if (rstate == 2 // paused document.write('<input name="cmd" value="Resume" type="submit">') else // running { document.write('<input name="cmd" value="Stop" type="submit">') document.write('<input name="cmd" value="Pause" type="submit">') } if (rstate == 1) // stopped document.write('<input name="customscript" value="tri_config" type="submit">'); </script>
514	23 Oct 2008	Konstantin Olchanski	Bug Report	Inconsistent handling of odb and evet buffer timeouts
In midas.c there are several places where client last activity time stamps are checked against the watchdog timeout and the clients are declared dead if they fail to update their activity time stamps. ODB time stamps and data buffer time stamps appear to be handled in a similar manner. Most checks are done like this: now = ss_millitime(); if (client->watchdog > 0 <----- check that the watchdog is enabled && now > client->last_activity <---- check for crazy time stamps from the future && now - client->last_activity > client->watchdog_timeout) <--- normal timeout remove_client(client); But in a few places, the extra checks are missing: now = ss_millitime(); if (now - client->last_activity > client->watchdog_timeout) remove_client(client); Is this an oversight from when additional checks were added? Should I make all checks read like the first one? K.O.
515	23 Oct 2008	Konstantin Olchanski	Bug Report	strange output from "odbedit cleanup"
When I run odbedit remotely (odbedit -h ladd09), the "cleanup" command unexpectedly produces the output of the "sor" command (sure enough, there is a call to db_get_open_records() there), but when I run it locally, I do not get this output (but db_get_open_records() is still called). Strange. K.O.

Goto page Previous 1, 2, 3 ... 97, 98, 99 ... 148, 149, 150 Next

ELOG V3.1.4-2e1708b5