ID |
Date |
Author |
Topic |
Subject |
|
76
|
01 Dec 2004 |
Konstantin Olchanski | Suggestion | Histogram zeroing, and extended histogram display manipulation |
> We need a simple way of zeroing online spectra, using the roody viewer to
> select which spectra are to be zeroed.
Problem confirmed: there is a button for "clear all", but no buttons for "clear
selected histograms" and "clear just this one histogram". It was suggested that the
right-click context menu for each histogram should have a "clear" action. Maybe same
for a "group".
> We would also like the histogram view to be unaffected by refreshing.
> Currently the y axis is autoscaled after a refresh.
I thought this was fixed a long time ago...
> We would also like a quicker way of manipulating the histogram display, than
> by the awkward, particularly for canvases containing multiple histograms, axis
> manipulation currently available.
I am thinking along the lines of locking the "zooming" of all histograms: on a 2x2
panel of histograms, rezooming any one of them would rezoom the others the same way.
> This could be a toolbar similar to the view
> editor that already exists - are the contents of this customisable, or would a
> separate toolbar be needed?, and would ideally contain the following ...
> 4 buttons, which could each be labelled with a single arrow, for shifting the
> histogram left/right/up/down (e.g. by half the corresponding axis's range). 4
> buttons, which could each be labelled with double arrows, for scaling the x/y
> axes (scaling by factors of 2 and 0.5, about the axis's initial position). 3
> buttons for toggling linear/log scale on each axis (these are in the current
> view editor). 3 more buttons, for resetting the view to default, for retaining
> the current view and for reverting to a previously retained view.
This does not sound like something I can do in 5 minutes, maybe Joe Chuma would take
this on?
> We would also like to be able to attach markers to a histogram (requiring
> another button to remove markers). markers would be placed using mouse clicks
> on the histogram, *and* by a text entry box for typing channel numbers. Markers
> would be labelled with x,y. There would then be a button to expand an axis
> between the last 2 placed markers. The markers would also be used for analysis
> such as integral and peakfind/fitting.
Maybe I am missing something, but is this not "standard root" functionality, using
the pad editor and adding "TLabels"?
> The view manipulation toolbar would be one per canvas, so there would also
> need to be a toggle button to apply the view manipulation commands to all the
> histograms on that canvas, or to just the currently selected histogram[s] (a way
> to select several, rather than just one, histograms would be useful)
I like this: a control for selecting if the action is applied to just one histogram
or to all histograms in a group.
> This would be very much quicker and easier to use than selecting items from
> long menus, which themselves need to be called by selecting specific, often very
> small, regions of a canvas.
I see: ROOT is geared very much for manipulating ONE graphical object at a time. We
want to manipulate MANY identical objects at the same time and the existing tools
are inadequate, for example because each object is physically very small and it is
hard to point-and-click it.
K.O. |
|
77
|
01 Dec 2004 |
Konstantin Olchanski | Suggestion | Histogram zeroing, and extended histogram display manipulation |
> > We would also like the histogram view to be unaffected by refreshing.
> > Currently the y axis is autoscaled after a refresh.
>
> I thought this was fixed a long time ago...
Never mind that.
Vertical scale of online histograms *has* to change after a refresh- the number of
counts in an online histogram increases as it accumulates more data and the histogram
would grow up out of the visual range unless it is rescaled.
Now, we can be smart about this: for a zoomed histogram, we can freeze the "y" scaling
or we can maintain the zoom ratio while rescaling.
K.O. |
|
78
|
20 Dec 2004 |
John M O'Donnell | Bug Fix | displaying cuts implementation |
Attached is a cvs patch to allow roody to display graphical cuts (TCutG).
Does somebody have the permissions to commit this patch to the cvs repository?
It also includes some hooks where code for updating a cut will be implmented.
Updating cuts will be done with another patch, to both roody and midas. This same
mechanism can be used for creating new cuts and sending them to the analyzer.
The final part of this project will be a change to midas to allow cuts to be booked
into (sub)folders. I have some code which I am using for testing purposes, but I
don't like where it stores the cuts for persistence between different invocations of
the analyzer. I'm thinking that cuts should be stored in last.root, and retrieved
from there.
John. |
| Attachment 1: cut_display.patch
|
? MTGListTreeDict.cxx
? MTGListTreeDict.h
? RoodyDict.cxx
? RoodyDict.h
? TGTextDialogDict.cxx
? TGTextDialogDict.h
? TNetFolderDict.cxx
? TNetFolderDict.h
? TPeakFindPanelDict.cxx
? TPeakFindPanelDict.h
? TXaxisLimitsDialogDict.cxx
? TXaxisLimitsDialogDict.h
? roody
Index: Roody.cxx
===================================================================
RCS file: /usr/local/cvsroot/roody/src/Roody.cxx,v
retrieving revision 1.42
diff -r1.42 Roody.cxx
284a285
> AddSetCut();
673a675,689
> void Roody::AddSetCut()
> {
> TClassMenuItem *menuItem = new TClassMenuItem( TClassMenuItem::kPopupUserFunction,
> Roody::Class(),
> "Send to Analyzer", "SetCut", this,
> "TObject*", 0);
> TCutG::Class()->GetMenuList()->AddFirst(menuItem);
> }
>
> void Roody::SetCut(TObject *o)
> {
> TCutG *cut = static_cast<TCutG*>(o);
> cout << "SetCut callback for " << cut->GetName() << " not yet implemented" << endl;
> }
>
989a1006,1010
> else if( obj->InheritsFrom(TCutG::Class()) )
> {
> TCutG *c = static_cast<TCutG*>(obj);
> c->Draw();
> }
2354a2376,2382
> else if( type && type->Contains("TCutG") && !found )
> {
> fFileOnlineContents->AddItem( item, itemDescription.c_str(),
> (void*)new TObjString(name.c_str()),
> gClient->GetPicture("cut_t.xpm"),
> gClient->GetPicture("cut_t.xpm") );
> }
2410a2439,2443
> else if (object->InheritsFrom(TCutG::Class()) )
> {
> TCutG *cut = static_cast<TCutG*>(object);
> DrawObject( dest, cut);
> }
Index: Roody.h
===================================================================
RCS file: /usr/local/cvsroot/roody/src/Roody.h,v
retrieving revision 1.36
diff -r1.36 Roody.h
259a260
> #include "TCutG.h"
305a307
> void SetCut(TObject *cut);
464a467
> void AddSetCut();
Index: TNetFolder.cpp
===================================================================
RCS file: /usr/local/cvsroot/roody/src/TNetFolder.cpp,v
retrieving revision 1.1
diff -r1.1 TNetFolder.cpp
49,51c49,54
< TObjArray *list = (TObjArray*) m->ReadObject(m->GetClass());
< delete m;
< return list;
---
> if (m) {
> TObjArray *list = (TObjArray*) m->ReadObject(m->GetClass());
> delete m;
> return list;
> }
> return 0;
|
|
79
|
07 Jan 2005 |
John M O'Donnell | Bug Fix | displaying cuts implementation |
> Attached is a cvs patch to allow roody to display graphical cuts (TCutG).
>
> Does somebody have the permissions to commit this patch to the cvs repository?
>
> It also includes some hooks where code for updating a cut will be implmented.
> Updating cuts will be done with another patch, to both roody and midas. This same
> mechanism can be used for creating new cuts and sending them to the analyzer.
>
> The final part of this project will be a change to midas to allow cuts to be booked
> into (sub)folders. I have some code which I am using for testing purposes, but I
> don't like where it stores the cuts for persistence between different invocations of
> the analyzer. I'm thinking that cuts should be stored in last.root, and retrieved
> from there.
>
> John.
cvs commit made today to support display of polygons, and sending polygons an analyzer.
A patch for mana.c so that MIDAS analyzers receive polygons has been sent to Stefan.
John. |
|
80
|
10 Jan 2005 |
Stefan Ritt | Bug Fix | displaying cuts implementation |
> A patch for mana.c so that MIDAS analyzers receive polygons has been sent to Stefan.
Patch has been submitted to CVS so mana.c is up-to-date.
- Stefan |
|
81
|
13 Jan 2005 |
John M O'Donnell | Bug Fix | displaying cuts implementation |
I have just sent a MIDAS patch to Stefan so that:
(1) cuts should be booked using TCutG *cut_book( const char *name).
Usage is similar to h1_book etc.
(2) cuts are saved in last.root.
(3) cuts are restored from last.root.
I also fixed a bug in receiving cuts from ROODY. The search for
cuts should be made only in gManaHistosFolder, not from gROOT.
Should this also be the case for GetPointer etc.?
I believe this implements a first pass at handling TCutG for MIDAS and ROODY.
To create a cut from scratch, one declares it in the analyzer init functions
using cut_book, and saves the pointer for use in the event-by-event code.
Then in ROODY, create a polygon, name it and send it to the analyzer (right click
on the polygon).
I believe the patchs which I have made should also be applied to ROME.
John. |
|
82
|
17 Jan 2005 |
Konstantin Olchanski | Info | CVS instructions |
Updated CVS instructions for ROODY:
1) cvs anonymous read-only access:
export CVS_RSH=ssh
cvs -d anoncvs@dasdevpc.triumf.ca:/usr/local/cvsroot checkout roody
(username: anoncvs, password: anoncvs)
2) read-write cvs access (requires user account on dasdevpc.triumf.ca)
export CVS_RSH=ssh
cvs -d USERNAME@dasdevpc.triumf.ca:/usr/local/cvsroot checkout roody
3) build instructions:
cvs ... checkout roody
cd roody/src
make
./roody {file.root,file.hbook,-Hhostname:port}
K.O. |
|
83
|
21 Jan 2005 |
Joe Chuma | Bug Fix | multi-thousand histogram display problems in Roody |
When opening a .root file, if there are more than 1000 histograms in the file,
the display is divided up into folders, where each folder holds 250 histograms
(except for the final folder, which may be smaller). This was done because of a
problem with TGListTree which only shows up with a large numbers of objects. |
|
84
|
24 Jan 2005 |
Joe Chuma | Bug Fix | multi-thousand histogram display problems in Roody - 2 |
A minor update to the previous bug fix...
Modified Roody.cxx to display the histogram name range instead of the counter
range on the subfolders when reading > 1000 histograms from a file. |
|
85
|
26 Jan 2005 |
Joe Chuma | Bug Fix | zooming in on a multiframe canvas |
A "ZoomOption" has been added to the context menu produced by right clicking
anywhere on a histogram frame. This opens up a new canvas, titled "Zoom
Canvas", containing a copy of the histogram in the original frame. |
|
86
|
28 Jan 2005 |
Joe Chuma | Bug Fix | fixing y-axis scales |
The y-axis scales can now be fixed just like the x-axis scales. Choose
YaxisLimits from the context menu when right-clicking on a histogram frame and a
small dialog box will open in which you can enter the min and max values. If
the frame is part of a multipad canvas, all pads on that canvas will be redrawn
with the new scales. Choose YaxisLimits again and click on the Unzoom button to
unzoom all pads on that canvas. |
|
87
|
31 Jan 2005 |
Joe Chuma | Bug Fix | changes to online connection and xml |
A timer has been added to check if the online socket remains valid. If, say,
the analyzer has been stopped while running Roody, this will be detected and the
connection closed, then, every second, that connection will be attempted until
successful. Also, the external dtd file, roody.dtd, has been eliminated in
favour of internal dtd verification. Please note that Roody is being linked with
Root version 4.00.08, as version 4.02.00 introduces problems, such as context
menu errors. |
|
88
|
01 Feb 2005 |
Joe Chuma | Bug Fix | fixed 2 problems introduced with yesterdays changes |
Two bugs were introduced yesterday...
-- program crashes when trying to connect online via roody -h nodename
(uninitialized pointer)
-- program crashes when restoring an xml file which tries to use the
external dtd file (unchecked error condition)
Both problems are now fixed. |
|
89
|
07 Feb 2005 |
Joe Chuma | Bug Fix | online timer fixed |
The online timer has been modified for testing whether the online connection is
still valid. If the connection is broken, the timer tests the connection every
second until it has reconnected. When the connection is finally remade, any
online histograms will again be refreshed as before. This is now being done
with just the original timer, as 2 timers seem to conflict with each other. |
|
90
|
10 Mar 2005 |
Joe Chuma | Bug Fix | online re-connection problem fixed |
Fixed segmentation fault problems that occurred when connected online, then
having the connection broken, then re-establishing the connection, and then
clicking on an online item in the main window. The problem is in TGListTree in
the ROOT code, and is fixed here by including 2 routines into MTGListTree. |
|
91
|
11 Mar 2005 |
Joe Chuma | Bug Fix | reset online histograms |
Roody can now reset online histograms via context menu or main menu. This
requires a small change in mana.c Also, fixed a problem with segmentation
faults when trying to connect to an invalid server port. |
|
92
|
18 Mar 2005 |
Joe Chuma | Bug Fix | context menu changes |
The group context menu options are changed to "Draw group", "Reset group" and
"Delete group", where "Reset group" means reset any online members of the group
and will only appear if there are online members in that group. Multiple
selections (left click while holding down the control key) now have a context
menu (right click to open) but the context menu for multiple selections will
only display "New canvas", "Add to group" and, if there are online members,
"Reset", since the options "Current pad", "Overlay on pad" and "Next pad" are
not relevant to multiple selections. Online folders now have a context menu
with "New canvas", "Add to group" and "Reset" options. |
|
93
|
31 Mar 2005 |
Stefan Ritt | Bug Fix | reset online histograms |
> Roody can now reset online histograms via context menu or main menu. This
> requires a small change in mana.c Also, fixed a problem with segmentation
> faults when trying to connect to an invalid server port.
I saw that you implemented a "Reset" function in root_server_thread. This is not
necessary. You have the more general "Command" function which was meant for that.
You specify the object name, type, method to execute and optional arguments. Right
now, only the "Reset" command is implemented, but that's what you need. Can you
check if roody works with that? If so, can you remove the "Reset" function again ?
Thanks,
Stefan |
|
94
|
12 Apr 2005 |
Joe Chuma | Bug Fix | modified reset option implementation |
The reset option has been modified to use the new "Command" option in mana.c
instead of the "Reset" option in mana.c, which has been removed. |
|
95
|
12 Apr 2005 |
Joe Chuma | Bug Fix | memory leak fix |
A memory leak was fixed in Roody.cxx, which occurred when updating a histogram
from a NetFolder object. |